Repository navigation
Fix isolated review admission, durable progress and trusted image caching - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A called review workflow could receive empty credential inputs despite a configured protected Environment, then lose the original broker error and leave the request without a terminal status. Declare named secret grants in generated callers, fail early on missing/ambiguous credentials, preserve sanitized stage/code/status diagnostics and recover only workload-bound requests and session leases. A separate administrator-only read-only OIDC check never admits a manual run to the credential broker.
Adds one App-owned progress comment with verified PR counts, request/run/review identity, leased updates, bounded retries and reconciliation of ambiguous POST responses. Failed workflow output remains permanently non-approving. Existing native inline reviews and publisher isolation remain intact. New setup uses a repository-specific CBReview textual alias; existing configured triggers remain compatible.
The trusted Docker build optionally uses pinned Buildx/GHA caching and executes by content ID. Cache stays disabled by default pending the included no-provider benchmark: import/export overhead may exceed the original short build.
Validation: Node 24 typecheck/lint/build and 124 tests; clean-source npm ci/check; actual workerd/D1; actionlint; Docker build and sandbox; npm audit (zero vulnerabilities); strict image scan (zero HIGH/CRITICAL); source secret scan and diff check. No real provider inference or paid fallback.
Rollout requires additive D1 migration 0003 and coordinated caller/Worker TRUSTED_WORKFLOW pins to the actual merged commit. Preserve the hosted OAuth gate and keep automatic merging disabled. See docs/review-rollout.md for exact recovery and acceptance limits. GitHub CI passed on the final feature commit. The no-provider benchmark measured 14s ordinary / 49s cold cache / 14s restored cache; cache stays off. Production read-back and real inference remain separate acceptance steps.